Firestore: query.test.ts: improve the test that resumes a query with existence filter to actually validate the existence filter. #7149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existence filter to actually validate the existence filter. This builds upon the test added in #7134
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (567,931 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
dconeybe
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Mar 23, 2023
… existence filter to actually validate the existence filter. This is a port of firebase/firebase-js-sdk#7149, and builds upon the test added in #4799.
dconeybe
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Mar 23, 2023
… existence filter to actually validate the existence filter. This is a port of firebase/firebase-js-sdk#7149, and builds upon the test added in #4799.
dconeybe
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Mar 23, 2023
… existence filter to actually validate the existence filter. This is a port of firebase/firebase-js-sdk#7149, and builds upon the test added in #4799.
milaGGL
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the test 'resuming a query should use existence filter to detect deletes' in query.test.ts, which was added by the previous PR #7134, to also validate that the existence filter sent from Watch was correct. This was achieved by adding some test-only "hooks" into the SDK's internals that enable the test to "listen" for existence filter mismatches.
Ported to the Android SDK in firebase/firebase-android-sdk#4813
Ported to the iOS SDK in firebase/firebase-ios-sdk#11209